From: alison.schofield@intel.com To: Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams Cc: linux-cxl@vger.kernel.org Subject: [PATCH v4 0/4] XOR Math Fixups: translation & position Date: Tue, 2 Jul 2024 22:29:48 -0700 Message-Id: X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xref: photonic.trudheim.com org.kernel.vger.linux-cxl:29259 Newsgroups: org.kernel.vger.linux-cxl Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail From: Alison Schofield Dropped tags on Patch 2 due to changes. Please Tag again. Changes in v4: - Patch 1: Updated commit msg/log The name tidy-ups eventually led to a 'fold' not a 'rename' - Patch 2: Rename the root decoder callback hpa_to_spa (Dan) - Patch 2: Remove hpa_to_spa as a param to cxl_root_decoder_alloc() - Patch 2: Add code comment that chunk check is modulo only (Fabio) - Patch 2: Add lore link to unit test in commit log (Fabio) - Cover Letter: Add an introduction (Dan) Link to v3: https://lore.kernel.org/cover.1719275633.git.alison.schofield@intel.com/ Begin cover letter: XOR Math Fixups are presented for both translation and position. Translation: The CXL driver intends to report DPAs and their SPA translation in the TRACE logs for CXL poison, general_media, and dram events. It is actually only logging the HPA, not the SPA. That works for CXL decodes using typical MODULO arithmetic where HPA==SPA, but not for XOR decodes. The driver needs to restore the XOR'd bits in order to get to the SPA and it doesn't. This means that address translations for root decoders using XOR maps are wrong. Specifically regions that interleave across 2,4,6,8,12, or 16 host bridges are affected. Interleaves using 1 or 3 host bridges, even if configured with XOR Arithmetic, do not use xormaps, and are safe. Aside from knowing that any address translation of a 1 or 3 way host bridge interleave is correct no matter the decode (XOR or MODULO), all others are suspect because the decode is actually transparent to users. Position: The position part of this patchset came from the discovery that the driver doesn't need to calculate a targets position in a region interleave set. The BIOS sets the target list and the driver can simply use that order. Presentation is as follows: Patch 1: Clean up - cxl_trace_hpa()-> cxl_dpa_to_hpa() Patch 2: cxl: Restore XOR'd position bits during address translation This completes the DPA->HPA->SPA translation, correcting the XOR address translation problem described above. Patch 3 & Patch 4 are paired. Patch 3 presents the new method for verifying a target position in the list and Patch 4 removes the old method. FYI - the reason I don't present the code removal first is because I think it is easier to read the diff if I leave in the old root decoder call back setup for calc_hb, insert the new call back along the same path, and then rip out the defunct calc_hb. That's the way I created the patchset and it may be an easier way for reviewers to follow along with the root decoder callback setup. Alison Schofield (4): cxl/core: Fold cxl_trace_hpa() into cxl_dpa_to_hpa() cxl: Restore XOR'd position bits during address translation cxl/region: Verify target positions using the ordered target list cxl: Remove defunct code calculating host bridge target positions drivers/cxl/acpi.c | 84 ++++++++++++++++----------------------- drivers/cxl/core/core.h | 8 ++-- drivers/cxl/core/mbox.c | 2 +- drivers/cxl/core/port.c | 20 +--------- drivers/cxl/core/region.c | 61 ++++++++++++++-------------- drivers/cxl/core/trace.h | 4 +- drivers/cxl/cxl.h | 11 ++--- 7 files changed, 77 insertions(+), 113 deletions(-) base-commit: 22a40d14b572deb80c0648557f4bd502d7e83826 -- 2.37.3 . From: Krzysztof Kozlowski To: Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] cxl/acpi: simplify returning pointer without cleanup Date: Wed, 3 Jul 2024 10:30:55 +0200 Message-ID: <20240703083055.95864-1-krzysztof.kozlowski@linaro.org> X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xref: photonic.trudheim.com org.kernel.vger.linux-cxl:29264 org.kernel.vger.linux-kernel:1266180 Newsgroups: org.kernel.vger.linux-cxl,org.kernel.vger.linux-kernel Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail Use 'return_ptr' helper for returning a pointer without cleanup for shorter code. Signed-off-by: Krzysztof Kozlowski --- drivers/cxl/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c index 571069863c62..1e4bed8a933e 100644 --- a/drivers/cxl/acpi.c +++ b/drivers/cxl/acpi.c @@ -339,7 +339,7 @@ static struct resource *alloc_cxl_resource(resource_size_t base, if (!res->name) return NULL; - return no_free_ptr(res); + return_ptr(res); } static int add_or_reset_cxl_resource(struct resource *parent, struct resource *res) -- 2.43.0 . Date: Wed, 03 Jul 2024 17:35:58 +0800 From: kernel test robot To: Dave Jiang Cc: Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , linux-cxl@vger.kernel.org Subject: [cxl:next] BUILD SUCCESS f3d70720e92c24c22e0e63c2588636edba33eb1a Message-ID: <202407031755.bi6xCPcA-lkp@intel.com> X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kernel.vger.linux-cxl:29267 Newsgroups: org.kernel.vger.linux-cxl Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git next branch HEAD: f3d70720e92c24c22e0e63c2588636edba33eb1a cxl/region: Simplify cxl_region_nid() elapsed time: 729m configs tested: 172 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc-13.2.0 alpha allyesconfig gcc-13.2.0 alpha defconfig gcc-13.2.0 arc allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240703 gcc-13.2.0 arc randconfig-002-20240703 gcc-13.2.0 arc vdk_hs38_smp_defconfig gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allnoconfig clang-19 arm allyesconfig gcc-13.2.0 arm defconfig clang-14 arm omap1_defconfig gcc-13.2.0 arm randconfig-001-20240703 clang-19 arm randconfig-002-20240703 gcc-13.2.0 arm randconfig-003-20240703 clang-19 arm randconfig-004-20240703 clang-19 arm s3c6400_defconfig gcc-13.2.0 arm spear13xx_defconfig gcc-13.2.0 arm wpcm450_defconfig gcc-13.2.0 arm64 allmodconfig clang-19 arm64 allnoconfig gcc-13.2.0 arm64 defconfig gcc-13.2.0 arm64 randconfig-001-20240703 clang-19 arm64 randconfig-002-20240703 gcc-13.2.0 arm64 randconfig-003-20240703 gcc-13.2.0 arm64 randconfig-004-20240703 gcc-13.2.0 csky allnoconfig gcc-13.2.0 csky defconfig gcc-13.2.0 csky randconfig-001-20240703 gcc-13.2.0 csky randconfig-002-20240703 gcc-13.2.0 hexagon allmodconfig clang-19 hexagon allnoconfig clang-19 hexagon allyesconfig clang-19 hexagon defconfig clang-19 hexagon randconfig-001-20240703 clang-16 hexagon randconfig-002-20240703 clang-19 i386 allmodconfig gcc-13 i386 allnoconfig gcc-13 i386 allyesconfig gcc-13 i386 buildonly-randconfig-001-20240703 clang-18 i386 buildonly-randconfig-002-20240703 gcc-13 i386 buildonly-randconfig-003-20240703 gcc-13 i386 buildonly-randconfig-004-20240703 gcc-13 i386 buildonly-randconfig-005-20240703 clang-18 i386 buildonly-randconfig-006-20240703 gcc-13 i386 defconfig clang-18 i386 randconfig-001-20240703 gcc-13 i386 randconfig-002-20240703 clang-18 i386 randconfig-003-20240703 gcc-13 i386 randconfig-004-20240703 gcc-11 i386 randconfig-005-20240703 clang-18 i386 randconfig-006-20240703 gcc-7 i386 randconfig-011-20240703 gcc-13 i386 randconfig-012-20240703 gcc-13 i386 randconfig-013-20240703 gcc-13 i386 randconfig-014-20240703 gcc-13 i386 randconfig-015-20240703 gcc-13 i386 randconfig-016-20240703 clang-18 loongarch allmodconfig gcc-13.2.0 loongarch allnoconfig gcc-13.2.0 loongarch defconfig gcc-13.2.0 loongarch randconfig-001-20240703 gcc-13.2.0 loongarch randconfig-002-20240703 gcc-13.2.0 m68k allmodconfig gcc-13.2.0 m68k allnoconfig gcc-13.2.0 m68k allyesconfig gcc-13.2.0 m68k defconfig gcc-13.2.0 m68k multi_defconfig gcc-13.2.0 microblaze allmodconfig gcc-13.2.0 microblaze allnoconfig gcc-13.2.0 microblaze allyesconfig gcc-13.2.0 microblaze defconfig gcc-13.2.0 mips allnoconfig gcc-13.2.0 mips ath25_defconfig clang-19 mips cu1000-neo_defconfig gcc-13.2.0 mips loongson3_defconfig gcc-13.2.0 nios2 allnoconfig gcc-13.2.0 nios2 defconfig gcc-13.2.0 nios2 randconfig-001-20240703 gcc-13.2.0 nios2 randconfig-002-20240703 gcc-13.2.0 openrisc allnoconfig gcc-13.2.0 openrisc allyesconfig gcc-13.2.0 openrisc defconfig gcc-13.2.0 parisc allmodconfig gcc-13.2.0 parisc allnoconfig gcc-13.2.0 parisc allyesconfig gcc-13.2.0 parisc defconfig gcc-13.2.0 parisc randconfig-001-20240703 gcc-13.2.0 parisc randconfig-002-20240703 gcc-13.2.0 parisc64 defconfig gcc-13.2.0 powerpc allmodconfig gcc-13.2.0 powerpc allnoconfig gcc-13.2.0 powerpc allyesconfig clang-19 powerpc mpc836x_rdk_defconfig clang-19 powerpc mpc885_ads_defconfig clang-19 powerpc randconfig-001-20240703 clang-19 powerpc randconfig-002-20240703 gcc-13.2.0 powerpc randconfig-003-20240703 clang-15 powerpc skiroot_defconfig clang-19 powerpc64 randconfig-001-20240703 gcc-13.2.0 powerpc64 randconfig-002-20240703 gcc-13.2.0 powerpc64 randconfig-003-20240703 clang-19 riscv allmodconfig clang-19 riscv allnoconfig gcc-13.2.0 riscv allyesconfig clang-19 riscv defconfig clang-19 riscv randconfig-001-20240703 clang-19 riscv randconfig-002-20240703 gcc-13.2.0 s390 allmodconfig clang-19 s390 allnoconfig clang-19 s390 allnoconfig gcc-13.2.0 s390 allyesconfig gcc-13.2.0 s390 defconfig clang-19 s390 randconfig-001-20240703 clang-15 s390 randconfig-002-20240703 clang-19 sh allmodconfig gcc-13.2.0 sh allnoconfig gcc-13.2.0 sh allyesconfig gcc-13.2.0 sh defconfig gcc-13.2.0 sh edosk7705_defconfig gcc-13.2.0 sh kfr2r09_defconfig gcc-13.2.0 sh randconfig-001-20240703 gcc-13.2.0 sh randconfig-002-20240703 gcc-13.2.0 sh rts7751r2dplus_defconfig gcc-13.2.0 sh sh7763rdp_defconfig gcc-13.2.0 sparc allmodconfig gcc-13.2.0 sparc64 defconfig gcc-13.2.0 sparc64 randconfig-001-20240703 gcc-13.2.0 sparc64 randconfig-002-20240703 gcc-13.2.0 um allmodconfig clang-19 um allnoconfig clang-17 um allnoconfig gcc-13.2.0 um allyesconfig gcc-13 um defconfig clang-19 um i386_defconfig gcc-13 um randconfig-001-20240703 clang-19 um randconfig-002-20240703 clang-19 um x86_64_defconfig clang-15 x86_64 allnoconfig clang-18 x86_64 allyesconfig clang-18 x86_64 buildonly-randconfig-001-20240703 clang-18 x86_64 buildonly-randconfig-002-20240703 gcc-9 x86_64 buildonly-randconfig-003-20240703 clang-18 x86_64 buildonly-randconfig-004-20240703 clang-18 x86_64 buildonly-randconfig-005-20240703 clang-18 x86_64 buildonly-randconfig-006-20240703 clang-18 x86_64 defconfig gcc-13 x86_64 randconfig-001-20240703 clang-18 x86_64 randconfig-002-20240703 gcc-8 x86_64 randconfig-003-20240703 gcc-13 x86_64 randconfig-004-20240703 clang-18 x86_64 randconfig-005-20240703 gcc-13 x86_64 randconfig-006-20240703 gcc-13 x86_64 randconfig-011-20240703 gcc-9 x86_64 randconfig-012-20240703 gcc-11 x86_64 randconfig-013-20240703 gcc-13 x86_64 randconfig-014-20240703 gcc-13 x86_64 randconfig-015-20240703 clang-18 x86_64 randconfig-016-20240703 clang-18 x86_64 randconfig-071-20240703 gcc-13 x86_64 randconfig-072-20240703 clang-18 x86_64 randconfig-073-20240703 clang-18 x86_64 randconfig-074-20240703 clang-18 x86_64 randconfig-075-20240703 gcc-9 x86_64 randconfig-076-20240703 clang-18 x86_64 rhel-8.3-rust clang-18 xtensa allnoconfig gcc-13.2.0 xtensa randconfig-001-20240703 gcc-13.2.0 xtensa randconfig-002-20240703 gcc-13.2.0 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki .