From: superm1@kernel.org To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-kernel@vger.kernel.org (open list), Mario Limonciello , Tony Murray Subject: [PATCH] PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports Date: Fri, 28 Jun 2024 19:17:43 -0500 Message-ID: <20240629001743.1573581-1-superm1@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xref: photonic.trudheim.com org.kernel.vger.linux-kernel:1262839 org.kernel.vger.linux-pci:144647 Newsgroups: org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail From: Mario Limonciello HP Spectre x360 Convertible 15-ch0xx is an Intel Kaby Lake-G system that contains an AMD Polaris Radeon dGPU. Attempting to use the dGPU fails with the following sequence: amdgpu 0000:01:00.0: not ready 1023ms after resume; waiting amdgpu 0000:01:00.0: not ready 2047ms after resume; waiting amdgpu 0000:01:00.0: not ready 4095ms after resume; waiting amdgpu 0000:01:00.0: not ready 8191ms after resume; waiting amdgpu 0000:01:00.0: not ready 16383ms after resume; waiting amdgpu 0000:01:00.0: not ready 32767ms after resume; waiting amdgpu 0000:01:00.0: not ready 65535ms after resume; giving up amdgpu 0000:01:00.0: Unable to change power state from D3cold to D0, device inaccessible [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 20secs aborting The issue is that the Root Port the dGPU is connected to can't handle the transition from D3cold to D0 so the dGPU can't properly exit runtime PM. The existing logic in pci_bridge_d3_possible() checks for systems that are newer than 2015 to decide that D3 is safe, but this system appears not to work properly. Add the system to bridge_d3_blacklist to prevent D3cold from being used. Reported-and-tested-by: Tony Murray Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3389 Signed-off-by: Mario Limonciello --- drivers/pci/pci.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 35fb1f17a589..65e3a550052f 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -2965,6 +2965,17 @@ static const struct dmi_system_id bridge_d3_blacklist[] = { DMI_MATCH(DMI_BOARD_VERSION, "95.33"), }, }, + { + /* + * Changing power state of root port dGPU is connected fails + * https://gitlab.freedesktop.org/drm/amd/-/issues/3229 + */ + .ident = "HP Spectre x360 Convertible 15-ch0xx", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_BOARD_NAME, "83BB"), + }, + }, #endif { } }; -- 2.43.0 . Date: Sat, 29 Jun 2024 10:29:22 +0800 From: kernel test robot To: "Krzysztof =?utf-8?Q?Wilczy=C5=84ski"?= Cc: linux-pci@vger.kernel.org Subject: [pci:controller/rockchip] BUILD SUCCESS 1a1bb493a3644fd6ee33cb5c4ca0a4d528d5286f Message-ID: <202406291020.7t9hw5Yn-lkp@intel.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Xref: photonic.trudheim.com org.kernel.vger.linux-pci:144649 Newsgroups: org.kernel.vger.linux-pci Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip branch HEAD: 1a1bb493a3644fd6ee33cb5c4ca0a4d528d5286f PCI: dw-rockchip: Depend on PCI_ENDPOINT if building endpoint mode support elapsed time: 1539m configs tested: 177 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc-13.2.0 alpha defconfig gcc-13.2.0 arc allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240628 gcc-13.2.0 arc randconfig-002-20240628 gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allnoconfig gcc-13.2.0 arm allyesconfig gcc-13.2.0 arm am200epdkit_defconfig gcc-13.2.0 arm bcm2835_defconfig gcc-13.2.0 arm davinci_all_defconfig gcc-13.2.0 arm defconfig gcc-13.2.0 arm multi_v5_defconfig gcc-13.2.0 arm mv78xx0_defconfig gcc-13.2.0 arm mvebu_v7_defconfig gcc-13.2.0 arm omap1_defconfig gcc-13.2.0 arm randconfig-001-20240628 gcc-13.2.0 arm randconfig-002-20240628 gcc-13.2.0 arm randconfig-003-20240628 gcc-13.2.0 arm randconfig-004-20240628 gcc-13.2.0 arm tegra_defconfig gcc-13.2.0 arm64 allmodconfig gcc-13.2.0 arm64 allnoconfig gcc-13.2.0 arm64 defconfig gcc-13.2.0 arm64 randconfig-001-20240628 gcc-13.2.0 arm64 randconfig-002-20240628 gcc-13.2.0 arm64 randconfig-003-20240628 gcc-13.2.0 arm64 randconfig-004-20240628 gcc-13.2.0 csky allnoconfig gcc-13.2.0 csky defconfig gcc-13.2.0 csky randconfig-001-20240628 gcc-13.2.0 csky randconfig-002-20240628 gcc-13.2.0 i386 allmodconfig clang-18 i386 allnoconfig clang-18 i386 allyesconfig clang-18 i386 buildonly-randconfig-001-20240628 gcc-10 i386 buildonly-randconfig-001-20240629 gcc-7 i386 buildonly-randconfig-002-20240628 gcc-10 i386 buildonly-randconfig-002-20240629 gcc-7 i386 buildonly-randconfig-003-20240628 gcc-10 i386 buildonly-randconfig-003-20240629 gcc-7 i386 buildonly-randconfig-004-20240628 gcc-10 i386 buildonly-randconfig-004-20240629 gcc-7 i386 buildonly-randconfig-005-20240628 gcc-10 i386 buildonly-randconfig-005-20240629 gcc-7 i386 buildonly-randconfig-006-20240628 gcc-10 i386 buildonly-randconfig-006-20240629 gcc-7 i386 defconfig clang-18 i386 randconfig-001-20240628 gcc-10 i386 randconfig-001-20240629 gcc-7 i386 randconfig-002-20240628 gcc-10 i386 randconfig-002-20240629 gcc-7 i386 randconfig-003-20240628 gcc-10 i386 randconfig-003-20240629 gcc-7 i386 randconfig-004-20240628 gcc-10 i386 randconfig-004-20240629 gcc-7 i386 randconfig-005-20240628 gcc-10 i386 randconfig-005-20240629 gcc-7 i386 randconfig-006-20240628 gcc-10 i386 randconfig-006-20240629 gcc-7 i386 randconfig-011-20240628 gcc-10 i386 randconfig-011-20240629 gcc-7 i386 randconfig-012-20240628 gcc-10 i386 randconfig-012-20240629 gcc-7 i386 randconfig-013-20240628 gcc-10 i386 randconfig-013-20240629 gcc-7 i386 randconfig-014-20240628 gcc-10 i386 randconfig-014-20240629 gcc-7 i386 randconfig-015-20240628 gcc-10 i386 randconfig-015-20240629 gcc-7 i386 randconfig-016-20240628 gcc-10 i386 randconfig-016-20240629 gcc-7 loongarch allmodconfig gcc-13.2.0 loongarch allnoconfig gcc-13.2.0 loongarch defconfig gcc-13.2.0 loongarch randconfig-001-20240628 gcc-13.2.0 loongarch randconfig-002-20240628 gcc-13.2.0 m68k allmodconfig gcc-13.2.0 m68k allnoconfig gcc-13.2.0 m68k allyesconfig gcc-13.2.0 m68k defconfig gcc-13.2.0 microblaze allmodconfig gcc-13.2.0 microblaze allnoconfig gcc-13.2.0 microblaze allyesconfig gcc-13.2.0 microblaze defconfig gcc-13.2.0 mips allnoconfig gcc-13.2.0 mips ath79_defconfig gcc-13.2.0 mips qi_lb60_defconfig gcc-13.2.0 nios2 allnoconfig gcc-13.2.0 nios2 defconfig gcc-13.2.0 nios2 randconfig-001-20240628 gcc-13.2.0 nios2 randconfig-002-20240628 gcc-13.2.0 openrisc allnoconfig gcc-13.2.0 openrisc allyesconfig gcc-13.2.0 openrisc defconfig gcc-13.2.0 parisc allmodconfig gcc-13.2.0 parisc allnoconfig gcc-13.2.0 parisc allyesconfig gcc-13.2.0 parisc defconfig gcc-13.2.0 parisc randconfig-001-20240628 gcc-13.2.0 parisc randconfig-002-20240628 gcc-13.2.0 parisc64 defconfig gcc-13.2.0 powerpc allmodconfig gcc-13.2.0 powerpc allnoconfig gcc-13.2.0 powerpc allyesconfig gcc-13.2.0 powerpc amigaone_defconfig gcc-13.2.0 powerpc klondike_defconfig gcc-13.2.0 powerpc mvme5100_defconfig gcc-13.2.0 powerpc ppc44x_defconfig gcc-13.2.0 powerpc randconfig-001-20240628 gcc-13.2.0 powerpc randconfig-002-20240628 gcc-13.2.0 powerpc randconfig-003-20240628 gcc-13.2.0 powerpc64 randconfig-001-20240628 gcc-13.2.0 powerpc64 randconfig-002-20240628 gcc-13.2.0 powerpc64 randconfig-003-20240628 gcc-13.2.0 riscv allmodconfig gcc-13.2.0 riscv allnoconfig gcc-13.2.0 riscv allyesconfig gcc-13.2.0 riscv defconfig gcc-13.2.0 riscv randconfig-001-20240628 gcc-13.2.0 riscv randconfig-002-20240628 gcc-13.2.0 s390 allnoconfig gcc-13.2.0 s390 defconfig gcc-13.2.0 s390 randconfig-001-20240628 gcc-13.2.0 s390 randconfig-002-20240628 gcc-13.2.0 sh allnoconfig gcc-13.2.0 sh defconfig gcc-13.2.0 sh lboxre2_defconfig gcc-13.2.0 sh randconfig-001-20240628 gcc-13.2.0 sh randconfig-002-20240628 gcc-13.2.0 sh rsk7264_defconfig gcc-13.2.0 sh sh7785lcr_defconfig gcc-13.2.0 sparc64 defconfig gcc-13.2.0 sparc64 randconfig-001-20240628 gcc-13.2.0 sparc64 randconfig-002-20240628 gcc-13.2.0 um allnoconfig gcc-13.2.0 um defconfig gcc-13.2.0 um i386_defconfig gcc-13.2.0 um randconfig-001-20240628 gcc-13.2.0 um randconfig-002-20240628 gcc-13.2.0 um x86_64_defconfig gcc-13.2.0 x86_64 allnoconfig clang-18 x86_64 allyesconfig clang-18 x86_64 buildonly-randconfig-001-20240628 gcc-13 x86_64 buildonly-randconfig-002-20240628 gcc-13 x86_64 buildonly-randconfig-003-20240628 gcc-13 x86_64 buildonly-randconfig-004-20240628 gcc-13 x86_64 buildonly-randconfig-005-20240628 gcc-13 x86_64 buildonly-randconfig-006-20240628 gcc-13 x86_64 defconfig clang-18 x86_64 kexec clang-18 x86_64 randconfig-001-20240628 gcc-13 x86_64 randconfig-002-20240628 gcc-13 x86_64 randconfig-003-20240628 gcc-13 x86_64 randconfig-004-20240628 gcc-13 x86_64 randconfig-005-20240628 gcc-13 x86_64 randconfig-006-20240628 gcc-13 x86_64 randconfig-011-20240628 gcc-13 x86_64 randconfig-012-20240628 gcc-13 x86_64 randconfig-013-20240628 gcc-13 x86_64 randconfig-014-20240628 gcc-13 x86_64 randconfig-015-20240628 gcc-13 x86_64 randconfig-016-20240628 gcc-13 x86_64 randconfig-071-20240628 gcc-13 x86_64 randconfig-072-20240628 gcc-13 x86_64 randconfig-073-20240628 gcc-13 x86_64 randconfig-074-20240628 gcc-13 x86_64 randconfig-075-20240628 gcc-13 x86_64 randconfig-076-20240628 gcc-13 x86_64 rhel-8.3-rust clang-18 x86_64 rhel-8.3 clang-18 xtensa allnoconfig gcc-13.2.0 xtensa randconfig-001-20240628 gcc-13.2.0 xtensa randconfig-002-20240628 gcc-13.2.0 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki . Date: Sat, 29 Jun 2024 12:15:43 +0800 From: kernel test robot To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Subject: [pci:hotplug] BUILD SUCCESS 618b29a346979aedcb80f19a97a3f23fa757bc7e Message-ID: <202406291242.OZilqPv5-lkp@intel.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kernel.vger.linux-pci:144650 Newsgroups: org.kernel.vger.linux-pci Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git hotplug branch HEAD: 618b29a346979aedcb80f19a97a3f23fa757bc7e PCI: acpiphp: Add missing MODULE_DESCRIPTION() macro elapsed time: 15101m configs tested: 47 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc-13.2.0 alpha defconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arm64 allnoconfig gcc-13.2.0 arm64 defconfig gcc-13.2.0 csky allnoconfig gcc-13.2.0 csky defconfig gcc-13.2.0 i386 allmodconfig gcc-13 i386 allnoconfig gcc-13 i386 allyesconfig gcc-13 i386 buildonly-randconfig-005-20240619 gcc-7 i386 buildonly-randconfig-006-20240619 gcc-7 i386 defconfig clang-18 i386 randconfig-001-20240619 gcc-7 i386 randconfig-002-20240619 gcc-7 i386 randconfig-004-20240619 gcc-7 i386 randconfig-006-20240619 gcc-9 i386 randconfig-013-20240619 gcc-13 i386 randconfig-016-20240619 gcc-13 loongarch allnoconfig gcc-13.2.0 loongarch defconfig gcc-13.2.0 m68k allnoconfig gcc-13.2.0 m68k defconfig gcc-13.2.0 microblaze allnoconfig gcc-13.2.0 microblaze defconfig gcc-13.2.0 mips allnoconfig gcc-13.2.0 nios2 allnoconfig gcc-13.2.0 nios2 defconfig gcc-13.2.0 openrisc allnoconfig gcc-13.2.0 openrisc defconfig gcc-13.2.0 parisc allnoconfig gcc-13.2.0 parisc defconfig gcc-13.2.0 parisc64 defconfig gcc-13.2.0 powerpc allnoconfig gcc-13.2.0 riscv allnoconfig gcc-13.2.0 sh allnoconfig gcc-13.2.0 sh defconfig gcc-13.2.0 sparc allnoconfig gcc-13.2.0 sparc defconfig gcc-13.2.0 sparc64 defconfig gcc-13.2.0 um i386_defconfig gcc-13 x86_64 allnoconfig clang-18 x86_64 allyesconfig clang-18 x86_64 defconfig gcc-13 x86_64 rhel-8.3-rust clang-18 xtensa allnoconfig gcc-13.2.0 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki . Date: Sat, 29 Jun 2024 18:03:02 +0800 From: kernel test robot To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Subject: [pci:err] BUILD SUCCESS 75c47c790f43c438761fc049fb9d438144a9db45 Message-ID: <202406291800.MOMPABra-lkp@intel.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kernel.vger.linux-pci:144657 Newsgroups: org.kernel.vger.linux-pci Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git err branch HEAD: 75c47c790f43c438761fc049fb9d438144a9db45 PCI/DPC: Disable DPC service on suspend elapsed time: 15230m configs tested: 55 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc-13.2.0 alpha defconfig gcc-13.2.0 arc allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allyesconfig gcc-13.2.0 arm64 allmodconfig clang-19 arm64 allnoconfig gcc-13.2.0 arm64 defconfig gcc-13.2.0 csky allnoconfig gcc-13.2.0 csky defconfig gcc-13.2.0 i386 allmodconfig gcc-13 i386 allnoconfig gcc-13 i386 allyesconfig gcc-13 i386 defconfig clang-18 loongarch allmodconfig gcc-13.2.0 loongarch allnoconfig gcc-13.2.0 loongarch defconfig gcc-13.2.0 m68k allmodconfig gcc-13.2.0 m68k allnoconfig gcc-13.2.0 m68k allyesconfig gcc-13.2.0 m68k defconfig gcc-13.2.0 microblaze allmodconfig gcc-13.2.0 microblaze allnoconfig gcc-13.2.0 microblaze allyesconfig gcc-13.2.0 microblaze defconfig gcc-13.2.0 mips allnoconfig gcc-13.2.0 nios2 allnoconfig gcc-13.2.0 nios2 defconfig gcc-13.2.0 openrisc allnoconfig gcc-13.2.0 openrisc allyesconfig gcc-13.2.0 openrisc defconfig gcc-13.2.0 parisc allmodconfig gcc-13.2.0 parisc allnoconfig gcc-13.2.0 parisc allyesconfig gcc-13.2.0 parisc defconfig gcc-13.2.0 parisc64 defconfig gcc-13.2.0 powerpc allmodconfig gcc-13.2.0 powerpc allnoconfig gcc-13.2.0 riscv allmodconfig clang-19 riscv allnoconfig gcc-13.2.0 riscv allyesconfig clang-19 sh allnoconfig gcc-13.2.0 sh defconfig gcc-13.2.0 sparc allnoconfig gcc-13.2.0 sparc defconfig gcc-13.2.0 sparc64 defconfig gcc-13.2.0 um i386_defconfig gcc-13 x86_64 allnoconfig clang-18 x86_64 allyesconfig clang-18 x86_64 defconfig gcc-13 x86_64 rhel-8.3-rust clang-18 xtensa allnoconfig gcc-13.2.0 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki . From: Lorenzo Bianconi To: linux-pci@vger.kernel.org Cc: ryder.lee@mediatek.com, jianjun.wang@mediatek.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, linux-mediatek@lists.infradead.org, lorenzo.bianconi83@gmail.com, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, nbd@nbd.name, dd@embedd.com, upstream@airoha.com, angelogioacchino.delregno@collabora.com Subject: [PATCH v3 0/4] Add Airoha EN7581 PCIe support Date: Sat, 29 Jun 2024 15:51:50 +0200 Message-ID: X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xref: photonic.trudheim.com org.kernel.vger.linux-pci:144663 Newsgroups: org.kernel.vger.linux-pci,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-devicetree Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail Introduce support for EN7581 SoC to mediatek-gen3 PCIe driver Changes since v2: - fix dt-bindings clock definitions - fix mtk_pcie_of_match ordering - add register definitions - move pcie-phy registers configuration in pcie-phy driver Changes since v1: - remove register magic values - remove delay magic values - cosmetics - fix dts binding for clock/reset Lorenzo Bianconi (4): dt-bindings: PCI: mediatek-gen3: add support for Airoha EN7581 PCI: mediatek-gen3: Add mtk_gen3_pcie_pdata data structure PCI: mediatek-gen3: Rely on reset_bulk APIs for PHY reset lines PCI: mediatek-gen3: Add Airoha EN7581 support .../bindings/pci/mediatek-pcie-gen3.yaml | 68 ++++++- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek-gen3.c | 175 ++++++++++++++++-- 3 files changed, 224 insertions(+), 21 deletions(-) -- 2.45.2 .