Content-Type: multipart/mixed; boundary="------------KmBJbHVrA7B63hUs4UnWG4ah" Message-ID: <54b537c6-aca4-45be-9df0-53c80a046930@dan.merillat.org> Date: Sun, 30 Jun 2024 13:27:07 -0400 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Language: en-US From: Dan Merillat To: Michal Kubecek , netdev Subject: ethtool fails to read some QSFP+ modules. Xref: photonic.trudheim.com org.kernel.vger.netdev:355329 Newsgroups: org.kernel.vger.netdev Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail This is a multi-part message in MIME format. --------------KmBJbHVrA7B63hUs4UnWG4ah Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit I was testing an older Kaiam XQX2502 40G-LR4 and ethtool -m failed with netlink error. It's treating a failure to read the optional page3 data as a hard failure. This patch allows ethtool to read qsfp modules that don't implement the voltage/temperature alarm data. --------------KmBJbHVrA7B63hUs4UnWG4ah Content-Type: text/x-patch; charset=UTF-8; name="0001-Some-qsfp-modules-do-not-support-page-3.patch" Content-Disposition: attachment; filename="0001-Some-qsfp-modules-do-not-support-page-3.patch" Content-Transfer-Encoding: base64 RnJvbSAzMTQ0ZmJmYzA4ZmJmYjkwZWNkYTQ4NDhmYzkzNTZiZGU4OTMzZDRhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYW4gTWVyaWxsYXQgPGdpdEBkYW4uZWdpbml0eS5j b20+CkRhdGU6IFN1biwgMzAgSnVuIDIwMjQgMTM6MTE6NTEgLTA0MDAKU3ViamVjdDogW1BB VENIXSBTb21lIHFzZnAgbW9kdWxlcyBkbyBub3Qgc3VwcG9ydCBwYWdlIDMKClRlc3RlZCBv biBhbiBvbGRlciBLYWlhbSBYUVgyNTAyIDQwRy1MUjQgbW9kdWxlLgpldGh0b29sIC1tIGFi b3J0cyB3aXRoIG5ldGxpbmsgZXJyb3IgZHVlIHRvIHBhZ2UgMwpub3QgZXhpc3Rpbmcgb24g dGhlIG1vZHVsZS4gSWdub3JlIHRoZSBlcnJvciBhbmQKbGVhdmUgbWFwLT5wYWdlXzAzaCBO VUxMLgotLS0KIHFzZnAuYyB8IDggKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9xc2ZwLmMgYi9xc2ZwLmMK aW5kZXggYTI5MjFmYi4uMGExNmI0MiAxMDA2NDQKLS0tIGEvcXNmcC5jCisrKyBiL3FzZnAu YwpAQCAtMTAzNyw5ICsxMDM3LDE1IEBAIHNmZjg2MzZfbWVtb3J5X21hcF9pbml0X3BhZ2Vz KHN0cnVjdCBjbWRfY29udGV4dCAqY3R4LAogCQlyZXR1cm4gMDsKIAogCXNmZjg2MzZfcmVx dWVzdF9pbml0KCZyZXF1ZXN0LCAweDMsIFNGRjg2MzZfUEFHRV9TSVpFKTsKKworCS8qIFNv bWUgbW9kdWxlcyBhcmUgcGFnZWQgYnV0IGRvIG5vdCBoYXZlIHBhZ2UgMDNoLiAgVGhpcwor CSAqIGlzIGEgbm9uLWZhdGFsIGVycm9yLCBhbmQgc2ZmODYzNl9kb21fcGFyc2UoKSBoYW5k bGVzIHRoaXMKKwkgKiBjb3JyZWN0bHkuCisJICovCiAJcmV0ID0gbmxfZ2V0X2VlcHJvbV9w YWdlKGN0eCwgJnJlcXVlc3QpOwogCWlmIChyZXQgPCAwKQotCQlyZXR1cm4gcmV0OworCQly ZXR1cm4gMDsKKwogCW1hcC0+cGFnZV8wM2ggPSByZXF1ZXN0LmRhdGEgLSBTRkY4NjM2X1BB R0VfU0laRTsKIAogCXJldHVybiAwOwotLSAKMi40NS4xCgo= --------------KmBJbHVrA7B63hUs4UnWG4ah-- .