Return-Path: From: Yafang Shao To: akpm@linux-foundation.org Cc: ying.huang@intel.com, mgorman@techsingularity.net, linux-mm@kvack.org, Yafang Shao Subject: [PATCH 0/3] mm/page_alloc: Introduce a new sysctl knob vm.pcp_batch_scale_max Date: Sun, 7 Jul 2024 17:49:53 +0800 Message-Id: <20240707094956.94654-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kvack.linux-mm:202828 Newsgroups: org.kvack.linux-mm Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail Background ========== In our containerized environment, we have a specific type of container that runs 18 processes, each consuming approximately 6GB of RSS. These processes are organized as separate processes rather than threads due to the Python Global Interpreter Lock (GIL) being a bottleneck in a multi-threaded setup. Upon the exit of these containers, other containers hosted on the same machine experience significant latency spikes. Investigation ============= My investigation using perf tracing revealed that the root cause of these spikes is the simultaneous execution of exit_mmap() by each of the exiting processes. This concurrent access to the zone->lock results in contention, which becomes a hotspot and negatively impacts performance. The perf results clearly indicate this contention as a primary contributor to the observed latency issues. + 77.02% 0.00% uwsgi [kernel.kallsyms] [k] mmput - 76.98% 0.01% uwsgi [kernel.kallsyms] [k] exit_mmap - 76.97% exit_mmap - 58.58% unmap_vmas - 58.55% unmap_single_vma - unmap_page_range - 58.32% zap_pte_range - 42.88% tlb_flush_mmu - 42.76% free_pages_and_swap_cache - 41.22% release_pages - 33.29% free_unref_page_list - 32.37% free_unref_page_commit - 31.64% free_pcppages_bulk + 28.65% _raw_spin_lock 1.28% __list_del_entry_valid + 3.25% folio_lruvec_lock_irqsave + 0.75% __mem_cgroup_uncharge_list 0.60% __mod_lruvec_state 1.07% free_swap_cache + 11.69% page_remove_rmap 0.64% __mod_lruvec_page_state - 17.34% remove_vma - 17.25% vm_area_free - 17.23% kmem_cache_free - 17.15% __slab_free - 14.56% discard_slab free_slab __free_slab __free_pages - free_unref_page - 13.50% free_unref_page_commit - free_pcppages_bulk + 13.44% _raw_spin_lock By enabling the mm_page_pcpu_drain() we can locate the pertinent page, with the majority of them being regular order-0 user pages. <...>-1540432 [224] d..3. 618048.023883: mm_page_pcpu_drain: page=0000000035a1b0b7 pfn=0x11c19c72 order=0 migratetyp e=1 <...>-1540432 [224] d..3. 618048.023887: => free_pcppages_bulk => free_unref_page_commit => free_unref_page_list => release_pages => free_pages_and_swap_cache => tlb_flush_mmu => zap_pte_range => unmap_page_range => unmap_single_vma => unmap_vmas => exit_mmap => mmput => do_exit => do_group_exit => get_signal => arch_do_signal_or_restart => exit_to_user_mode_prepare => syscall_exit_to_user_mode => do_syscall_64 => entry_SYSCALL_64_after_hwframe The servers experiencing these issues are equipped with impressive hardware specifications, including 256 CPUs and 1TB of memory, all within a single NUMA node. The zoneinfo is as follows, Node 0, zone Normal pages free 144465775 boost 0 min 1309270 low 1636587 high 1963904 spanned 564133888 present 296747008 managed 291974346 cma 0 protection: (0, 0, 0, 0) ... pagesets cpu: 0 count: 2217 high: 6392 batch: 63 vm stats threshold: 125 cpu: 1 count: 4510 high: 6392 batch: 63 vm stats threshold: 125 cpu: 2 count: 3059 high: 6392 batch: 63 ... The pcp high is around 100 times the batch size. I also traced the latency associated with the free_pcppages_bulk() function during the container exit process: nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 148 |***************** | 512 -> 1023 : 334 |****************************************| 1024 -> 2047 : 33 |*** | 2048 -> 4095 : 5 | | 4096 -> 8191 : 7 | | 8192 -> 16383 : 12 |* | 16384 -> 32767 : 30 |*** | 32768 -> 65535 : 21 |** | 65536 -> 131071 : 15 |* | 131072 -> 262143 : 27 |*** | 262144 -> 524287 : 84 |********** | 524288 -> 1048575 : 203 |************************ | 1048576 -> 2097151 : 284 |********************************** | 2097152 -> 4194303 : 327 |*************************************** | 4194304 -> 8388607 : 215 |************************* | 8388608 -> 16777215 : 116 |************* | 16777216 -> 33554431 : 47 |***** | 33554432 -> 67108863 : 8 | | 67108864 -> 134217727 : 3 | | The latency can reach tens of milliseconds. Experimenting ============= vm.percpu_pagelist_high_fraction -------------------------------- The kernel version currently deployed in our production environment is the stable 6.1.y, and my initial strategy involves optimizing the vm.percpu_pagelist_high_fraction parameter. By increasing the value of vm.percpu_pagelist_high_fraction, I aim to diminish the batch size during page draining, which subsequently leads to a substantial reduction in latency. After setting the sysctl value to 0x7fffffff, I observed a notable improvement in latency. nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 120 | | 256 -> 511 : 365 |* | 512 -> 1023 : 201 | | 1024 -> 2047 : 103 | | 2048 -> 4095 : 84 | | 4096 -> 8191 : 87 | | 8192 -> 16383 : 4777 |************** | 16384 -> 32767 : 10572 |******************************* | 32768 -> 65535 : 13544 |****************************************| 65536 -> 131071 : 12723 |************************************* | 131072 -> 262143 : 8604 |************************* | 262144 -> 524287 : 3659 |********** | 524288 -> 1048575 : 921 |** | 1048576 -> 2097151 : 122 | | 2097152 -> 4194303 : 5 | | However, augmenting vm.percpu_pagelist_high_fraction can also decrease the pcp high watermark size to a minimum of four times the batch size. While this could theoretically affect throughput, as highlighted by Ying[0], we have yet to observe any significant difference in throughput within our production environment after implementing this change. Backporting the series "mm: PCP high auto-tuning" ------------------------------------------------- My second endeavor was to backport the series titled "mm: PCP high auto-tuning"[1], which comprises nine individual patches, into our 6.1.y stable kernel version. Subsequent to its deployment in our production environment, I noted a pronounced reduction in latency. The observed outcomes are as enumerated below: nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 2 | | 2048 -> 4095 : 11 | | 4096 -> 8191 : 3 | | 8192 -> 16383 : 1 | | 16384 -> 32767 : 2 | | 32768 -> 65535 : 7 | | 65536 -> 131071 : 198 |********* | 131072 -> 262143 : 530 |************************ | 262144 -> 524287 : 824 |************************************** | 524288 -> 1048575 : 852 |****************************************| 1048576 -> 2097151 : 714 |********************************* | 2097152 -> 4194303 : 389 |****************** | 4194304 -> 8388607 : 143 |****** | 8388608 -> 16777215 : 29 |* | 16777216 -> 33554431 : 1 | | Compared to the previous data, the maximum latency has been reduced to less than 30ms. Adjusting the CONFIG_PCP_BATCH_SCALE_MAX ---------------------------------------- Upon Ying's suggestion, adjusting the CONFIG_PCP_BATCH_SCALE_MAX can potentially reduce the PCP batch size without compromising the PCP high watermark size. This approach could mitigate latency spikes without adversely affecting throughput. Consequently, my third attempt focused on modifying this configuration. To facilitate easier adjustments, I replaced CONFIG_PCP_BATCH_SCALE_MAX with a new sysctl knob named vm.pcp_batch_scale_max. By fine-tuning vm.pcp_batch_scale_max from its default value of 5 down to 0, I achieved a further reduction in the maximum latency, which was lowered to less than 2ms: nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 36 | | 2048 -> 4095 : 5063 |***** | 4096 -> 8191 : 31226 |******************************** | 8192 -> 16383 : 37606 |*************************************** | 16384 -> 32767 : 38359 |****************************************| 32768 -> 65535 : 30652 |******************************* | 65536 -> 131071 : 18714 |******************* | 131072 -> 262143 : 7968 |******** | 262144 -> 524287 : 1996 |** | 524288 -> 1048575 : 302 | | 1048576 -> 2097151 : 19 | | After multiple trials, I observed no significant differences between each attempt. The Proposal ============ This series encompasses two minor refinements to the PCP high watermark auto-tuning mechanism, along with the introduction of a new sysctl knob that serves as a more practical alternative to the previous configuration method. Future improvement to zone->lock ================================ To ultimately mitigate the zone->lock contention issue, several suggestions have been proposed. One approach involves dividing large zones into multi smaller zones, as suggested by Matthew[2], while another entails splitting the zone->lock using a mechanism similar to memory arenas and shifting away from relying solely on zone_id to identify the range of free lists a particular page belongs to[3]. However, implementing these solutions is likely to necessitate a more extended development effort. Link: https://lore.kernel.org/linux-mm/874j98noth.fsf@yhuang6-desk2.ccr.corp.intel.com/ [0] Link: https://lore.kernel.org/all/20231016053002.756205-1-ying.huang@intel.com/ [1] Link: https://lore.kernel.org/linux-mm/ZnTrZ9mcAIRodnjx@casper.infradead.org/ [2] Link: https://lore.kernel.org/linux-mm/20240705130943.htsyhhhzbcptnkcu@techsingularity.net/ [3] Changes: - mm: Enable setting -1 for vm.percpu_pagelist_high_fraction to set the minimum pagelist https://lore.kernel.org/linux-mm/20240701142046.6050-1-laoar.shao@gmail.com/ Yafang Shao (3): mm/page_alloc: A minor fix to the calculation of pcp->free_count mm/page_alloc: Avoid changing pcp->high decaying when adjusting CONFIG_PCP_BATCH_SCALE_MAX mm/page_alloc: Introduce a new sysctl knob vm.pcp_batch_scale_max Documentation/admin-guide/sysctl/vm.rst | 15 ++++++++++ include/linux/sysctl.h | 1 + kernel/sysctl.c | 2 +- mm/Kconfig | 11 ------- mm/page_alloc.c | 38 ++++++++++++++++++------- 5 files changed, 45 insertions(+), 22 deletions(-) -- 2.43.5 . Return-Path: Date: Sun, 7 Jul 2024 22:37:28 +0800 From: kernel test robot To: Jagadeesh Kona Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Bjorn Andersson , Bryan O'Donoghue , Dmitry Baryshkov , Vladimir Zapolskiy Subject: [linux-next:master 7766/10451] drivers/clk/qcom/camcc-sm8650.c:3573:36: error: passing argument 1 of 'qcom_cc_really_probe' from incompatible pointer type Message-ID: <202407072212.WptVaUDt-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-linux-mm@kvack.org X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kvack.linux-mm:202834 Newsgroups: org.kvack.linux-mm,dev.linux.lists.oe-kbuild-all Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 0b58e108042b0ed28a71cd7edf5175999955b233 commit: 09ea421652a832083ea380a72addf383965f3682 [7766/10451] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240707/202407072212.WptVaUDt-lkp@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407072212.WptVaUDt-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407072212.WptVaUDt-lkp@intel.com/ Note: the linux-next/master HEAD 0b58e108042b0ed28a71cd7edf5175999955b233 builds fine. It may have been fixed somewhere. All errors (new ones prefixed by >>): drivers/clk/qcom/camcc-sm8650.c: In function 'cam_cc_sm8650_probe': >> drivers/clk/qcom/camcc-sm8650.c:3573:36: error: passing argument 1 of 'qcom_cc_really_probe' from incompatible pointer type [-Werror=incompatible-pointer-types] 3573 | ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap); | ^~~~~~~~~~ | | | struct device * In file included from drivers/clk/qcom/camcc-sm8650.c:19: drivers/clk/qcom/common.h:63:57: note: expected 'struct platform_device *' but argument is of type 'struct device *' 63 | extern int qcom_cc_really_probe(struct platform_device *pdev, | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~ cc1: some warnings being treated as errors vim +/qcom_cc_really_probe +3573 drivers/clk/qcom/camcc-sm8650.c 3535 3536 static int cam_cc_sm8650_probe(struct platform_device *pdev) 3537 { 3538 struct regmap *regmap; 3539 int ret; 3540 3541 ret = devm_pm_runtime_enable(&pdev->dev); 3542 if (ret) 3543 return ret; 3544 3545 ret = pm_runtime_resume_and_get(&pdev->dev); 3546 if (ret) 3547 return ret; 3548 3549 regmap = qcom_cc_map(pdev, &cam_cc_sm8650_desc); 3550 if (IS_ERR(regmap)) { 3551 pm_runtime_put(&pdev->dev); 3552 return PTR_ERR(regmap); 3553 } 3554 3555 clk_lucid_ole_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config); 3556 clk_lucid_ole_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config); 3557 clk_rivian_evo_pll_configure(&cam_cc_pll2, regmap, &cam_cc_pll2_config); 3558 clk_lucid_ole_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config); 3559 clk_lucid_ole_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config); 3560 clk_lucid_ole_pll_configure(&cam_cc_pll5, regmap, &cam_cc_pll5_config); 3561 clk_lucid_ole_pll_configure(&cam_cc_pll6, regmap, &cam_cc_pll6_config); 3562 clk_lucid_ole_pll_configure(&cam_cc_pll7, regmap, &cam_cc_pll7_config); 3563 clk_lucid_ole_pll_configure(&cam_cc_pll8, regmap, &cam_cc_pll8_config); 3564 clk_lucid_ole_pll_configure(&cam_cc_pll9, regmap, &cam_cc_pll9_config); 3565 clk_lucid_ole_pll_configure(&cam_cc_pll10, regmap, &cam_cc_pll10_config); 3566 3567 /* Keep clocks always enabled */ 3568 qcom_branch_set_clk_en(regmap, 0x13318); /* CAM_CC_DRV_AHB_CLK */ 3569 qcom_branch_set_clk_en(regmap, 0x13314); /* CAM_CC_DRV_XO_CLK */ 3570 qcom_branch_set_clk_en(regmap, 0x132ec); /* CAM_CC_GDSC_CLK */ 3571 qcom_branch_set_clk_en(regmap, 0x13308); /* CAM_CC_SLEEP_CLK */ 3572 > 3573 ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap); 3574 3575 pm_runtime_put(&pdev->dev); 3576 3577 return ret; 3578 } 3579 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki . Return-Path: Date: Sun, 7 Jul 2024 22:48:55 +0800 From: kernel test robot To: Nick Terrell Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:master 10437/10451] riscv32-linux-ld: section .data..percpu VMA [c2591000,c259730b] overlaps section __ksymtab VMA [c2582828,c259537f] Message-ID: <202407072240.F2G1kQX2-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-linux-mm@kvack.org X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kvack.linux-mm:202835 Newsgroups: org.kvack.linux-mm,dev.linux.lists.oe-kbuild-all Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 0b58e108042b0ed28a71cd7edf5175999955b233 commit: 58bd9b396896ad2c8d5a4ac293bd8a98c726245b [10437/10451] Merge branch 'zstd-next' of https://github.com/terrelln/linux.git config: riscv-randconfig-r042-20221215 (https://download.01.org/0day-ci/archive/20240707/202407072240.F2G1kQX2-lkp@intel.com/config) compiler: riscv32-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407072240.F2G1kQX2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407072240.F2G1kQX2-lkp@intel.com/ All errors (new ones prefixed by >>): riscv32-linux-ld: section .data LMA [00603000,00a02f2b] overlaps section .text LMA [00082fa0,01fb8c2b] riscv32-linux-ld: section .pci_fixup VMA [c257fb88,c2582827] overlaps section .bss VMA [c2439000,c2590b27] >> riscv32-linux-ld: section .data..percpu VMA [c2591000,c259730b] overlaps section __ksymtab VMA [c2582828,c259537f] riscv32-linux-ld: section __ksymtab_gpl VMA [c2595380,c25ab8a3] overlaps section .data..percpu VMA [c2591000,c259730b] fs/reiserfs/super.o: in function `handle_attrs': fs/reiserfs/super.c:1410:(.text+0x118): relocation truncated to fit: R_RISCV_GPREL_I against `.LC0' fs/reiserfs/super.o: in function `init_inodecache': fs/reiserfs/super.c:669:(.init.text+0x2c): relocation truncated to fit: R_RISCV_GPREL_I against `.LC41' fs/ext4/super.o: in function `_ext4_show_options': fs/ext4/super.c:3024:(.text+0x2c64): relocation truncated to fit: R_RISCV_GPREL_I against `.LC34' fs/f2fs/super.o: in function `f2fs_show_quota_options': fs/f2fs/super.c:1862:(.text+0x20c4): relocation truncated to fit: R_RISCV_GPREL_I against `.LC52' drivers/clk/clk-max9485.o: in function `max9485_i2c_probe': drivers/clk/clk-max9485.c:268:(.text+0x244): relocation truncated to fit: R_RISCV_GPREL_I against `.LC0' drivers/usb/gadget/udc/gr_udc.o: in function `__preempt_count_sub': include/asm-generic/preempt.h:59:(.text+0x2364): relocation truncated to fit: R_RISCV_GPREL_I against `.LC41' drivers/media/i2c/imx290.o: in function `imx290_probe': drivers/media/i2c/imx290.c:1618:(.text+0xca0): relocation truncated to fit: R_RISCV_GPREL_I against `.LC9' drivers/media/i2c/ov5640.o: in function `ov5640_set_power_mipi': drivers/media/i2c/ov5640.c:2544:(.text+0x3aec): relocation truncated to fit: R_RISCV_GPREL_I against `.LC11' drivers/media/i2c/ov7670.o: in function `ov7670_probe': drivers/media/i2c/ov7670.c:1838:(.text+0x16ec): relocation truncated to fit: R_RISCV_GPREL_I against `.LC3' drivers/media/i2c/st-mipid02.o: in function `mipid02_probe': drivers/media/i2c/st-mipid02.c:810:(.text+0xb4c): relocation truncated to fit: R_RISCV_GPREL_I against `.LC9' fs/reiserfs/fix_node.o: in function `ip_check_balance': fs/reiserfs/fix_node.c:1696:(.text+0x42ac): additional relocation overflows omitted from the output -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki . Return-Path: Date: Sun, 7 Jul 2024 23:20:36 +0800 From: kernel test robot To: Jagadeesh Kona Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Bjorn Andersson , Bryan O'Donoghue , Dmitry Baryshkov , Vladimir Zapolskiy Subject: [linux-next:master 7766/10451] drivers/clk/qcom/camcc-sm8650.c:3573:29: error: incompatible pointer types passing 'struct device *' to parameter of type 'struct platform_device *' Message-ID: <202407072331.baglL4Sd-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-linux-mm@kvack.org X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Xref: photonic.trudheim.com org.kvack.linux-mm:202836 Newsgroups: org.kvack.linux-mm,dev.linux.lists.llvm,dev.linux.lists.oe-kbuild-all Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 0b58e108042b0ed28a71cd7edf5175999955b233 commit: 09ea421652a832083ea380a72addf383965f3682 [7766/10451] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407072331.baglL4Sd-lkp@intel.com/ Note: the linux-next/master HEAD 0b58e108042b0ed28a71cd7edf5175999955b233 builds fine. It may have been fixed somewhere. All errors (new ones prefixed by >>): >> drivers/clk/qcom/camcc-sm8650.c:3573:29: error: incompatible pointer types passing 'struct device *' to parameter of type 'struct platform_device *' [-Werror,-Wincompatible-pointer-types] 3573 | ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap); | ^~~~~~~~~~ drivers/clk/qcom/common.h:63:57: note: passing argument to parameter 'pdev' here 63 | extern int qcom_cc_really_probe(struct platform_device *pdev, | ^ 1 error generated. vim +3573 drivers/clk/qcom/camcc-sm8650.c 3535 3536 static int cam_cc_sm8650_probe(struct platform_device *pdev) 3537 { 3538 struct regmap *regmap; 3539 int ret; 3540 3541 ret = devm_pm_runtime_enable(&pdev->dev); 3542 if (ret) 3543 return ret; 3544 3545 ret = pm_runtime_resume_and_get(&pdev->dev); 3546 if (ret) 3547 return ret; 3548 3549 regmap = qcom_cc_map(pdev, &cam_cc_sm8650_desc); 3550 if (IS_ERR(regmap)) { 3551 pm_runtime_put(&pdev->dev); 3552 return PTR_ERR(regmap); 3553 } 3554 3555 clk_lucid_ole_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config); 3556 clk_lucid_ole_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config); 3557 clk_rivian_evo_pll_configure(&cam_cc_pll2, regmap, &cam_cc_pll2_config); 3558 clk_lucid_ole_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config); 3559 clk_lucid_ole_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config); 3560 clk_lucid_ole_pll_configure(&cam_cc_pll5, regmap, &cam_cc_pll5_config); 3561 clk_lucid_ole_pll_configure(&cam_cc_pll6, regmap, &cam_cc_pll6_config); 3562 clk_lucid_ole_pll_configure(&cam_cc_pll7, regmap, &cam_cc_pll7_config); 3563 clk_lucid_ole_pll_configure(&cam_cc_pll8, regmap, &cam_cc_pll8_config); 3564 clk_lucid_ole_pll_configure(&cam_cc_pll9, regmap, &cam_cc_pll9_config); 3565 clk_lucid_ole_pll_configure(&cam_cc_pll10, regmap, &cam_cc_pll10_config); 3566 3567 /* Keep clocks always enabled */ 3568 qcom_branch_set_clk_en(regmap, 0x13318); /* CAM_CC_DRV_AHB_CLK */ 3569 qcom_branch_set_clk_en(regmap, 0x13314); /* CAM_CC_DRV_XO_CLK */ 3570 qcom_branch_set_clk_en(regmap, 0x132ec); /* CAM_CC_GDSC_CLK */ 3571 qcom_branch_set_clk_en(regmap, 0x13308); /* CAM_CC_SLEEP_CLK */ 3572 > 3573 ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap); 3574 3575 pm_runtime_put(&pdev->dev); 3576 3577 return ret; 3578 } 3579 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki . Date: Mon, 8 Jul 2024 01:05:03 +0800 From: kernel test robot To: Suren Baghdasaryan Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Kees Cook Subject: ERROR: modpost: "mem_alloc_profiling_key" [arch/powerpc/kvm/kvm-hv.ko] undefined! Message-ID: <202407080044.DWMC9N9I-lkp@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Xref: photonic.trudheim.com org.kernel.vger.linux-kernel:1270192 org.kvack.linux-mm:202839 Newsgroups: org.kernel.vger.linux-kernel,dev.linux.lists.oe-kbuild-all,org.kvack.linux-mm Path: photonic.trudheim.com!nntp.lore.kernel.org!not-for-mail tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c6653f49e4fd3b0d52c12a1fc814d6c5b234ea15 commit: d224eb0287fbd84f4f13eca042c7f08f87138f3b codetag: debug: mark codetags for reserved pages as empty date: 2 months ago config: powerpc64-randconfig-r112-20240707 (https://download.01.org/0day-ci/archive/20240708/202407080044.DWMC9N9I-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20240708/202407080044.DWMC9N9I-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ All errors (new ones prefixed by >>, old ones prefixed by <<): WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/8250/serial_cs.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/serial_mctrl_gpio.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/n_gsm.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/iommu/iova.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/panel/panel-auo-a030jtn01.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/panel/panel-innolux-ej030na.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/panel/panel-novatek-nt39016.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/panel/panel-orisetech-ota5601a.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/bridge/lontium-lt9611.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/bridge/sii9234.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/tiny/bochs.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_panel_orientation_quirks.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_mipi_dbi.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/base/regmap/regmap-slimbus.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/base/regmap/regmap-sccb.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/arizona.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/pcf50633-gpio.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/rt4831.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dax/dax.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/scsi/scsi_common.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/scsi/advansys.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/scsi/BusLogic.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/scsi/elx/efct.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/scsi/atp870u.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spi/spi-bitbang.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spi/spi-fsl-lib.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/charlcd.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/hd44780_common.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/line-display.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pcmcia/yenta_socket.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pcmcia/i82092.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/input/vivaldi-fmap.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/i2c/busses/i2c-ccgx-ucsi.o WARNING: modpost: drivers/media/i2c/et8ek8/et8ek8: section mismatch in reference: et8ek8_i2c_driver+0x10 (section: .data) -> et8ek8_remove (section: .exit.text) WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/tuners/tda9887.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/platform/marvell/mcam-core.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/v4l2-core/v4l2-async.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/v4l2-core/v4l2-fwnode.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/corsair-cpro.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/cpufreq-dt-platdev.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/flash/leds-rt4505.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firmware/google/coreboot_table.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firmware/google/framebuffer-coreboot.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firmware/google/cbmem.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firmware/google/vpd-sysfs.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/crypto/atmel-sha204a.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-a4tech.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-aureal.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-cherry.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-cypress.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-dr.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-emsff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-elecom.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-vivaldi-common.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-magicmouse.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-mf.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-monterey.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ortek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-pl.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-petalynx.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-primax.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-redragon.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-saitek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sjoy.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sunplus.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-tivo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-twinhan.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-xinmo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-viewsonic.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/greybus/gb-hid.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/greybus/gb-power-supply.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/greybus/gb-audio-manager.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/greybus/gb-gpio.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/greybus/gb-spi.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/greybus/gb-spilib.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rpmsg/rpmsg_char.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_performance.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_powersave.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_userspace.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvmem/nvmem_u-boot-env.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-gpio.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/vdpa/vdpa.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/vdpa/ifcvf/ifcvf.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mtd/chips/cfi_util.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mtd/chips/cfi_cmdset_0020.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mtd/maps/map_funcs.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/vhost/vringh.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/codecs/snd-soc-sigmadsp.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/codecs/snd-soc-wm-adsp.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/xilinx/snd-soc-xlnx-i2s.o >> ERROR: modpost: "mem_alloc_profiling_key" [arch/powerpc/kvm/kvm-hv.ko] undefined! >> ERROR: modpost: "page_ext_get" [arch/powerpc/kvm/kvm-hv.ko] undefined! >> ERROR: modpost: "page_ext_put" [arch/powerpc/kvm/kvm-hv.ko] undefined! -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki .